fix(prose-tests): the stop hook records, and names the model that walked#559
Open
leeovery wants to merge 1 commit into
Open
fix(prose-tests): the stop hook records, and names the model that walked#559leeovery wants to merge 1 commit into
leeovery wants to merge 1 commit into
Conversation
The walker has declared a stop hook for weeks and it has never written a line. Every other event is scoped to its world by finding the world path in the payload; a stop event carries no tool input, so there was nothing to match and the record was silently dropped. Nothing failed — the record was simply short, which is the failure mode this whole subsystem exists to prevent. The stop payload does name the agent's own harness transcript, and that file states the model each message ran on. Resolving the world from the transcript revives the hook and, in the same read, answers a question the verdicts could not previously answer: which model produced this result. That matters because an edited agent definition does not reach a running session until its plugins are reloaded. A walk can therefore run on a model nobody intended, and every verdict in that run is trusted at the wrong one with nothing on the page to show it. The model now travels from the harness record through the asserter into the orchestrator's verdict block, so a stale definition is visible in the output instead of being something to remember. Also hardens the asserter-violation log — it appends to a path whose parent it never created, so a contract breach went unrecorded anywhere the directory was absent — and drops a stale claim in the orchestrator's description that it escalates failures to Opus, which it has not done since both agents moved to the same model. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prose-walkerdeclares a stop hook, butrecord-action.cjsscopes every event to a world by finding the world path in the payload — and a stop event carries no tool input, so there was nothing to match. The record was silently short. Its world now resolves from the agent transcript the payload points at.tests/scripts/test-prose-record-action.cjs(14 tests, registered innpm test) — the recorder had no suite, which is how the dead hook stayed invisible. Covers both world-resolution paths, model extraction (single, multiple, unreadable, partial trailing line), the asserter contract, and the never-break-what-it-observes guarantees.Test plan
node --test tests/scripts/test-prose-record-action.cjs— 14/14node --test tests/scripts/test-prose-cases.cjs tests/scripts/test-prose-snapshots.cjs— 35/35 with the new suiteSubagentStop: resolves the world from the transcript, extracts the model, tolerates a truncated line, writes one uniform rowagent_transcript_pathproved a walk ran onclaude-opus-5while the definition on disk saidsonnet, which is the case this change makes visible🤖 Generated with Claude Code
Stack